Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist results in s3 #18

Merged
merged 10 commits into from Apr 6, 2023
Merged

Persist results in s3 #18

merged 10 commits into from Apr 6, 2023

Conversation

ayazhafiz
Copy link
Member

@ayazhafiz ayazhafiz commented Apr 5, 2023

Implements persistence of results to a remote persistence task.

Results are only persisted to a remote when

  • there are no pending results-persistence tasks left in the queue
  • the initial manifest is already complete

This is to avoid starvation by way of continuously persisting to the remote.

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Bigtest for 869552f (run)

Benchmarks:

  • RSpec: 6.94% overhead
    • RSpec time: 17.72 seconds
    • ABQ time: 18.95 seconds
  • RSpec parallel, 10 runs: max 16.99% overhead
    • min 7.11% overhead
    • standard deviation: 2.93%
  • Jest: 4.18% overhead
    • Jest time: 20.172 seconds
    • ABQ time: 21.016 seconds

Fuzz result sizes:

  • PASSED

@ayazhafiz ayazhafiz marked this pull request as ready for review April 6, 2023 15:12
@ayazhafiz ayazhafiz enabled auto-merge (squash) April 6, 2023 15:21
@ayazhafiz ayazhafiz requested a review from doxavore April 6, 2023 15:21
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Bigtest for f83a3ce (run)

Benchmarks:

  • RSpec: 9.84% overhead
    • RSpec time: 17.79 seconds
    • ABQ time: 19.54 seconds
  • RSpec parallel, 10 runs: max 15.35% overhead
    • min 6.63% overhead
    • standard deviation: 2.85%
  • Jest: 5.11% overhead
    • Jest time: 20.442 seconds
    • ABQ time: 21.486 seconds

Fuzz result sizes:

  • PASSED

Copy link
Member

@kylekthompson kylekthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒

@ayazhafiz ayazhafiz merged commit 47dcfd5 into main Apr 6, 2023
17 checks passed
@ayazhafiz ayazhafiz deleted the persist-results-in-s3 branch April 6, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants