Integrate dumping manifests to remote as part of manifest persistence #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayazhafiz
force-pushed
the
remote-persist-manifests
branch
from
d7f0e9b
to
e696428
Compare
TAGraves
reviewed
Apr 5, 2023
| // TODO(PERF): write to remote in parallel by passing the in-memory bytes instead. | ||
| self.remote | ||
| .store(PersistenceKind::Manifest, run_id, &path) | ||
| .await?; |
There was a problem hiding this comment.
What do you think we should do if this fails? It'd be nice to retry it a few times with backoff in the background (does the S3 remote impl already do that?)
There was a problem hiding this comment.
S3 will retry twice. Yeah, we should probably retry with backoff anyway though.
TAGraves
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, when a queue persists a manifest to local disk after the initial manifest has been handed out, it will also persist that manifest to a remote (if any).
Needs #4 first.