Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipping inflections for Rails 3.2.x versions too #115

Closed

Conversation

2468ben
Copy link

@2468ben 2468ben commented Mar 18, 2015

I was running Rails version 3.2.18 and still getting the inflector error, so just wanted to skip it for 3.2.x

@@ -5,7 +5,7 @@ class Engine < Rails::Engine
end

initializer "ember-cli-rails.inflector" do
if Rails.version > "3.2"
if Rails.version > "3.2.x"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be > "4", i think

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"4.0.0"  > "4" # => true
"3.2.10" > "4" # => false

@rwz rwz closed this in c754ae0 Mar 20, 2015
@2468ben
Copy link
Author

2468ben commented Mar 25, 2015

Thank you sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants