Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to inject options into download #38

Open
philipwhiuk opened this issue Nov 6, 2018 · 1 comment
Open

Ability to inject options into download #38

philipwhiuk opened this issue Nov 6, 2018 · 1 comment

Comments

@philipwhiuk
Copy link

philipwhiuk commented Nov 6, 2018

Hi,

I'm using cldr-data to get the core Unicode CLDR data. Unfortunately, having had it working fine, I'm now behind a corporate proxy that uses a different CA.

It seems like request takes options which can include a CA certificate and (worst case) just disabling TLS checks: https://github.com/request/request/blob/master/request.js#L254

However, the downloader doesn't allow you to pass in any options.

return download({

Would you accept a PR that added:

options.downloadOptions

which got spread into that object.

Then in cldr-data

"cldr-data-download-options" which was passed into the downloader as options.downloadOptions?

NB: For this specific issue I'm hopefuly I can work round this by doing

export NODE_EXTRA_CA_CERTS=ca-cert/ca-cert.crt

@rxaviers
Copy link
Owner

rxaviers commented Nov 6, 2018

Sure, looks good to me. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants