Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix problems of resizing #7

Closed
wants to merge 1 commit into from

Conversation

chirsz-ever
Copy link

Let me explain the point. The resize opertion in demo is like that currently:
gif0
If the cursor's position may make the window's size too small, its size won't shrink more. That's all right. But the window's size enlarge as soon as the cursor move backward rather than keep its size until the cursor move out of the original press position, which windows in other GUI platforms perform.
gif1
I revise some code and this is the effect:
gif2
I add two members into mu_Context so that more than one mu_Context could work on the same process. the modifications does not destroy the library's lightweight and fixed-sized memory region.

@chirsz-ever
Copy link
Author

In fact I am new hand at git and github, and I just learned how to use git rebase to simplify commits today.
It's a good experience to contribute to this great project :)

add modification for muti contexts
@chirsz-ever
Copy link
Author

I rebased this branch to the latest commit of the master branch. The change should be easy to read and understand.
I apologize if I did offend or distrub you, please believe that is not my intention.
Lastly, If you insist on not to merge this PR, please close it.

@rxi
Copy link
Owner

rxi commented Mar 3, 2020

Sorry for taking so long to get back to you on this -- I don't feel the functionality that this change provides is worth the added code complexity it adds, even if it is minor.

That being said, thanks for taking the time to contribute and putting in the effort to so clearly outline the changes with embedded gifs.

@rxi rxi closed this Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants