Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language configs should be provided from outside #28

Open
Hamzali opened this issue Mar 24, 2020 · 4 comments
Open

Language configs should be provided from outside #28

Hamzali opened this issue Mar 24, 2020 · 4 comments

Comments

@Hamzali
Copy link

Hamzali commented Mar 24, 2020

Love the library thank you for this awesome work :)

MomentJS is awesome as well however the biggest pain point for me was the size of the language and internalization options, however, most of the time I use two or three languages at most.

I think language data could be given as a dict from outside with typed configuration values and language codes as keys because every language will increase the size of the package and limits the language aspect. Maybe every language set can be a separate package this way

Any ideas or plans about how can the internalization problem decoupled from the date formatting problem at hand?

@janwirth
Copy link

Unused languages will be tree-shaken out anyways AFAIK.

@Hamzali
Copy link
Author

Hamzali commented Mar 27, 2020

If it is the case then I would love to add Turkish translations because I will need it for my current project :)
I just open a PR right? Anything important to know beforehand?

@janwirth
Copy link

You can inject them locally for now AFAIK - I needed german but only for relative date formatting. So partially translating works.

@Hamzali
Copy link
Author

Hamzali commented Apr 18, 2020

ok, thanks for the help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants