Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step-Signal #4

Open
kreutziger opened this issue Jun 23, 2014 · 3 comments
Open

Step-Signal #4

kreutziger opened this issue Jun 23, 2014 · 3 comments

Comments

@kreutziger
Copy link

Would not it be useful to submit not only error but also stdout via signal? Like a signal called 'step', which returns the output single handedly so they can be processed internally.

It is easy to implement in the makestep-method, I think.

@kreutziger kreutziger changed the title Step-Sginal Step-Signal Jun 23, 2014
@ryan-self
Copy link
Owner

@kreutziger Thanks for looking into the exec-plan project, and providing recommendations for future development! :)

I'm more of a visual learner, so it would be helpful if you could provide a code example of using exec-plan, with the change that you want; that way I can understand more specifically what you're requesting. In the code example, assume that you have the interface you want already implemented.

Also, I haven't looked at this project's code in over a year, so I would need to get reacquainted with main.js again. If you have a specific code change recommendation, feel free to include that in a reply, along with the code example requested above.

Thanks!

@kreutziger
Copy link
Author

Hello,

sorry for the late reply, I think I got no E-Mail for that reply ^^.

I think the only change I made [0], was in line 96, but I am not sure about it. It works for me so far.

[0] http://pastebin.com/76F1Jbj9

@ryan-self
Copy link
Owner

@kreutziger,

Haha, no worries ;)

I looked at what you did, and I think it makes sense to provide a convenience event called "step" that will allow users to have event handlers for each (non-final) step. It may be useful to think a little more on what the step event should provide the user. Currently, you have it as stdout, but we may want to include things like "command", "step number", etc... I will think on this further, and welcome any suggestions.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants