Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip installation of attic when installed #21

Merged
merged 1 commit into from
May 25, 2024

Conversation

pfzetto
Copy link
Contributor

@pfzetto pfzetto commented May 17, 2024

This PR adds a check to skip the installation of attic when attic -V returns with exit code 0.

Closes #20

Copy link
Owner

@ryanccn ryanccn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the designated formatter (Prettier)! pnpm run format should do the trick.

src/stages/install.ts Outdated Show resolved Hide resolved
src/stages/install.ts Outdated Show resolved Hide resolved
Adds a check to skip the installation of `attic` when
`attic -V` returns with exit code 0.
@pfzetto
Copy link
Contributor Author

pfzetto commented May 17, 2024

Sorry, I implemented the suggested changes and ran the formatter.

Copy link
Collaborator

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanccn ryanccn merged commit 5619ef4 into ryanccn:main May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Skip installation when attic in PATH
3 participants