Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputfieldPageListSelectMultiple module bug #701

Closed
MrEd69 opened this issue Sep 30, 2014 · 4 comments
Closed

InputfieldPageListSelectMultiple module bug #701

MrEd69 opened this issue Sep 30, 2014 · 4 comments

Comments

@MrEd69
Copy link

MrEd69 commented Sep 30, 2014

Hello, I am not sure if I am the first one to find this bug, but...

How to reproduce:
Create field FieldsetTabOpen (lets name test_tab)
Create field Page (lets name test), choose Multiple pages, and type PageListSelectMultiple

Add the fields to template:

test_tab
test
test_tab_END

The field "test" is not sortable. The reason is because the InputfieldPageListSelectMultiple.init is called before the tabs are rendered.
My very quick workaround was to move the init method call into setTimeout, but I am not sure if this the correct choice.

wire/modules/Inputfield/InputfieldPageListSelect/InputfieldPageListSelectMultiple.module:88 now looks like the line below.
"setTimeout(function() { InputfieldPageListSelectMultiple.init($('#{$this->id}_items')); }, 200);" .

Processwire version 2.4

Topic in forum: https://processwire.com/talk/topic/7774-inputfieldpagelistselectmultiple-module-bug/

@ryancramerdesign
Copy link
Owner

This one is already fixed in PW 2.5. Just to confirm, I followed your steps, and all seems to work well here. Let me know if you continue to experience the issue after upgrading.

@isellsoap
Copy link
Collaborator

@MrEd69 Can this be closed? Please look also to other PRs or issues of you (if there are any), that could be closed. Thanks!

@isellsoap
Copy link
Collaborator

@ryancramerdesign Since @MrEd69 doesn’t close the issue, can you do it?

@isellsoap
Copy link
Collaborator

@MrEd69 This issue seems to be fixed, thus I close it. If you think the issue isn’t fixed yet or requires additional work to do, please consider reopening it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants