Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows #40

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

punya
Copy link

@punya punya commented Jul 19, 2023

Fixes #1

@punya punya force-pushed the windows-support branch 3 times, most recently from 8bc32e8 to b79dc73 Compare July 19, 2023 02:57
@ryandens
Copy link
Owner

Ideally this would include an automated job that runs a build on windows github action - I admit I don't use windows for development so not sure the best way to approach this. Very open to changes in the plugin build and the plugin to enable both to work seamlessly on windows machines. Mostly, I'm concerned about accidentally introducing a future change that breaks windows without me having a way of knowing about it.

@punya punya marked this pull request as ready for review July 19, 2023 03:34
@punya punya marked this pull request as draft July 19, 2023 04:32
@punya
Copy link
Author

punya commented Jul 19, 2023

CI failed on macOS:

> Task :plugin:functionalTest

com.ryandens.javaagent.JavaagentPluginFunctionalTest > can attach to application run task FAILED
    org.gradle.testkit.runner.UnexpectedBuildFailure at JavaagentPluginFunctionalTest.kt:227


8 tests completed, 1 failed
> Task :plugin:functionalTest FAILED

...but I can't reproduce this locally on macOS. I think this might be a flaky test (I saw it fail in this way once and then pass again).

@ryandens
Copy link
Owner

Huh, that's interesting. I activated the build scan from that build, and it looks like the simple-agent jar is not present at the time that test executes 🤔 https://scans.gradle.com/s/lu7fzdilc6rlq/tests/overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for windows
2 participants