Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternative to use the translation without connector to the components #3

Closed
stefensuhat opened this issue Jun 28, 2017 · 3 comments

Comments

@stefensuhat
Copy link

No description provided.

@stefensuhat stefensuhat changed the title Add alternative to use the translation without connect. Add alternative to use the translation without connecting to the components. Jun 28, 2017
@stefensuhat stefensuhat changed the title Add alternative to use the translation without connecting to the components. Add alternative to use the translation without connector to the components Jun 28, 2017
@ryandrewjohnson
Copy link
Owner

I'm not 100% sure what the request is, but I am working an update to the translate function that would allow you to easily pass multiple translations down to a child component, but the parent component would still need to be connected. I'm hoping to have this new feature ready by end of week.

In meantime if you want to provide some more detail on your issue I might be able to better answer.

@ryandrewjohnson
Copy link
Owner

ryandrewjohnson commented Jul 9, 2017

I have added the new feature I mentioned. See Pass multiple translations to child components.

I'm also going to mark this as closed since there's been no further details provided.

@ieow
Copy link

ieow commented Jul 22, 2017

I think he meant component connected with getTranslate would rerender on every action dispacthed.
I tried using selector to prevent unnecessary rerendering.
const translateSelector = createSelector( state=>state.locale, (locale) => getTranslate(locale)
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants