Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assimilate concat pipe module. #7

Closed
ryanelian opened this issue Jun 4, 2017 · 1 comment
Closed

Assimilate concat pipe module. #7

ryanelian opened this issue Jun 4, 2017 · 1 comment

Comments

@ryanelian
Copy link
Owner

ryanelian commented Jun 4, 2017

Currently concat task relies on gulp-concat and event-stream by making multiple pipes and then merging them.

Adding salt to the pain, the gulp.src relies on array of string containing relative / absolute file paths, not resolved file paths. Not to mention that concatResolution getter property on CompilerSettings is using synchronous resolve logic.

By rewriting, performance can be improved and at the same time removing 2 dependencies from the project.

how-to:

EDIT: rewritten concatenation list resolution using async-await Promise.

@ryanelian
Copy link
Owner Author

Resolved with 09fb668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant