Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addItemType breaks translations #58

Closed
ldrshv opened this issue Dec 8, 2022 · 3 comments
Closed

addItemType breaks translations #58

ldrshv opened this issue Dec 8, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@ldrshv
Copy link

ldrshv commented Dec 8, 2022

I found a strange bug. FilamentNavigation::addItemType breaks translations of buttons and placeholders on select. If you change Select to TextInput, everything is fine.

image
image
image

@ryangjchandler ryangjchandler added the bug Something isn't working label Dec 8, 2022
@ryangjchandler
Copy link
Owner

Thanks, I'll investigate this later today.

@kaitwalla
Copy link

kaitwalla commented Mar 8, 2023

Having this same issue; interestingly, it also breaks translations elsewhere (for example, on the RichEditor fields in completely separate areas of Filament). Any ideas/ETA on a fix?

I've been beating my head against this for the better part of several hours. Apologies because I'm just trying to get back into Laravel after a while away.

No matter how I change it, whenever the Facade gets called outside the plugin context, that's when translations break. Even calling the exact same code after packageBooted in FilamentNavigationServiceProvider lets everything work. It's only when called outside of that context that the Select field eats it, regardless of what options are used. All other fields I tested worked.

@kaitwalla
Copy link

kaitwalla commented Mar 8, 2023

Well, shows what I know. If you register the custom types in AppServiceProvider::boot they work fine.

@ryangjchandler ryangjchandler closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants