Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExoPlayer revisited #19

Closed
ryanheise opened this issue Dec 31, 2019 · 7 comments
Closed

ExoPlayer revisited #19

ryanheise opened this issue Dec 31, 2019 · 7 comments
Assignees

Comments

@ryanheise
Copy link
Owner

A number of recent issues (#10, #14, #16, and possibly #17) could be addressed by finally switching to ExoPlayer as per the suggestion of @rohansohonee . The reason for not considering it until now was the difficulty of implementing untilPosition in ExoPlayer, however studying the APIs further, I think this should actually be possible as well.

It will take some time to read through all the documentation, but I plan to focus my attention here for the next while.

@ryanheise
Copy link
Owner Author

The latest commit now integrates ExoPlayer, for testing.

I have not yet changed anything substantial in behaviour, but this will make it easier resolve the other open issues listed above.

@rohansohonee
Copy link

rohansohonee commented Dec 31, 2019

Will test and report.
(Edit)
Can you please set the min sdk to 16.

@cnttechio
Copy link

I'm very happy when you integrate Exoplayer. I will try to use it in my app and report to you if I have issues.

@ryanheise
Copy link
Owner Author

@rohansohonee Done.

@rohansohonee
Copy link

@ryanheise
In java in the audioplayer constructor the player.addListener(this) is being used as the same listener when creating two instances of audioplayer in dart code.
The id are different but the listener is same.
This means on stopping player A, the player B also stops.

Am I correct???

@ryanheise
Copy link
Owner Author

That shouldn't be the case, since each instance of the audio player results in a new instance of the Java AudioPlayer class.

@github-actions
Copy link

github-actions bot commented Nov 8, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs, or use StackOverflow if you need help with just_audio.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants