Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Add 1.0.0-alpha.8 -> 0.2.7 compat layer #10

Merged
merged 2 commits into from Aug 21, 2022
Merged

wip: Add 1.0.0-alpha.8 -> 0.2.7 compat layer #10

merged 2 commits into from Aug 21, 2022

Conversation

silvergasp
Copy link
Contributor

@silvergasp silvergasp commented Jul 9, 2022

Closes #9

TODO:

  • Update to new traits
  • Get new compat layer building
  • Implement new compat layer
  • Update docs/tests and ensure passing/building

@har7an
Copy link
Contributor

har7an commented Aug 2, 2022

Hi there,

may/shall I lend a hand in implementing this, maybe? I'm trying to bump rust-radio-sx128x to 1.0.0-alpha8, and it depends on this crate via a whole bunch of intermediary crates, so I'm very interested in having this available upstream.

@silvergasp
Copy link
Contributor Author

Yeah, I'd be glad for the help. I've had other priorities pop up and probably won't get back to this for another week or two.

Feel free to fork my repo and have a go at it. I'm not sure how it'd go logistically with a fork of a fork. If there is anything that you have questions about, feel free to tag me.

@silvergasp
Copy link
Contributor Author

Thanks to @har7an this is now ready to merge. There are still some issues with the doctests (which seemed to be broken before I started this PR) I've opened issue #11 to track that.

@silvergasp silvergasp marked this pull request as ready for review August 11, 2022 15:47
@ryankurte
Copy link
Owner

lgtm, thanks for all your efforts! once we've fixed #11 i'll tag a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support 1.0.0-alpha.8
3 participants