Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obviate need to specify vnc_auto.html and path to websocket #4

Open
ryanlovett opened this issue Apr 4, 2018 · 3 comments
Open

Obviate need to specify vnc_auto.html and path to websocket #4

ryanlovett opened this issue Apr 4, 2018 · 3 comments

Comments

@ryanlovett
Copy link
Owner

We currently use the notebook extension to visit vnc_auto.html and pass in a query string parameter to set the path to the websocket. Visiting /novnc should be sufficient to get things going.

@ryanlovett
Copy link
Owner Author

We no longer need to explicitly visit the html landing page via 91551a6.

The parameter could be replaced by a cookie with novnc/noVNC#1055.

@ryanlovett
Copy link
Owner Author

Created a different PR, novnc/noVNC#1056, which would serve the websocket at the same path as noVNC's other assets. This would obviate the need to set a query string var or cookie.

@ryanlovett
Copy link
Owner Author

The above PRs were declined. Resubmitted as novnc/noVNC#1058 using a different approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant