-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE]: Add a Configuration Table #9
Comments
From what your stating you would prefer to have the constructor be changed from new(parent: GuiObject, time: number?, style: EasingStyle?, direction: EasingDirection?, repeatCount: number?, reverses: boolean?, delayTime: number?) to new(parent: GuiObject, tweenInfo: TweenInfo?) or something similar. The TweenInfo data type already can be used instead of a table. Shime aims to be as familiar and easy to use as possible so it would make sense to borrow TweenInfo table, which is very much in scope of Shime. Currently as it stands if I do change the constructor, it would break backwards compatibility with the previous, including LTS releases of Shime. |
Yeah that is better ;) For now I gotta close this I found how to fix this function Shime.new(parent: GuiObject, tweenInfo: TweenInfo?)
tweenInfo = tweenInfo or TweenInfo.new(1, Enum.EasingStyle.Linear, Enum.EasingDirection.InOut, -1, false, 0)
local self = setmetatable({}, Shime)
-- Create the shimmer frame and animation
local shimmer = createShimmer(parent)
self._frame = shimmer
self._gradient = shimmer:FindFirstChildOfClass("UIGradient")
self._corner = shimmer:FindFirstChildOfClass("UICorner")
-- Create the tween
self._tween = TweenService:Create(
self._gradient,
tweenInfo,
{ Offset = Vector2.new(1, 0) }
)
-- Setup tween completion callback. Under default constants this will never be called as the tween will repeat infinitely
self._tween.Completed:Connect(function()
self:_TweenCompleted()
end)
return self
end |
I didn't push any commits? I'm not sure how I solved this issue but alright. |
You mentioned this:
|
I'm not planning to introduce a new constructor yet as it will break all pre-existing ones and require me to update all documentation for a small change which gives little benefits. So I don't get why this is marked as completed. |
Contact Details
https://devforum.roblox.com/u/vscplays/summary
Is your feature request related to a problem?
I have an problem when I was adding some values, It makes the code harder for me to read
these are the properties
Describe the solution you'd like
I would like to see the configuration table of these properties
Describe alternatives you've considered
No response
Additional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: