Skip to content
This repository has been archived by the owner on Jun 19, 2019. It is now read-only.

readdirSyncRecursive returns file names on Linux, file paths on Windows #26

Closed
domenic opened this issue May 1, 2012 · 2 comments
Closed
Assignees

Comments

@domenic
Copy link
Contributor

domenic commented May 1, 2012

This caused some problems deploying from a Windows dev environment to a Linux production environment :-/.

@ryanmcgrath
Copy link
Owner

Hmm... I don't have a VM to test on at the moment. Is this down to a platform difference in Node.js, by any chance? If so I feel like it's more of an upstream bug for them.

@ghost ghost assigned ryanmcgrath May 13, 2012
@domenic domenic mentioned this issue May 14, 2012
@domenic
Copy link
Contributor Author

domenic commented May 14, 2012

Nah, just down to using manual string manipulation instead of the path module.

There are lots of other places in the code that do such string manipulation (e.g. concatenation with / instead of using path.join), but all the tests pass on Windows now, so it seems likely they don't matter.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants