netbox 3.6 support (Sourcery refactored) #168

sourcery-ai · 2023-10-14T15:06:44Z

Pull Request #167 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the netbox_3.6 branch, then run:

git fetch origin sourcery/netbox_3.6
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai · 2023-10-14T15:06:46Z

.devcontainer/configuration/configuration.py

-        f = open('/run/secrets/' + secret_name, 'r', encoding='utf-8')
+        f = open(f'/run/secrets/{secret_name}', 'r', encoding='utf-8')


Function _read_secret refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2023-10-14T15:06:46Z

.devcontainer/configuration/configuration.py

-    if env_value == None:
+    if env_value is None:
        return env_value

-    if not map_fn:
-        return env_value
-
-    return map_fn(env_value)
+    return env_value if not map_fn else map_fn(env_value)


Function _environ_get_and_map refactored with the following changes:

Use x is None rather than x == None (none-compare)

Lift code into else after jump in control flow (reintroduce-else)

Replace if statement with if expression (assign-if-exp)