This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
Fixes to main branch + fixes to previously merged features #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 30, 2021 00:04
* fixed a bug in a finalize feature logic, which was caused by using a variable from previous loop, instead of properly-scoped variable. this lead to misbehavior (which is very hard to reproduce in different environments); * fixed message for the complaints loading directory.
* put __init__.py back in the 'complaints' module, now it's working; * added explicit option to enable 'inline' mode when the number of lines is 0, otherwise still show the error; * fixed module import code (still broken for commit-hook, somehow); * display full paths in errors; * warn about 'glob' that is going to cause an error, because it's empty (the error will happen when renag tries to read the file, but it's a dir).
|
Appreciate the move to |
When git executable is not present, renag should behave in the same way as it does in a normal directory. But since it might lead to unexpected result, we warn user about the fact that executable is missing without checking whether it was intended to be a git repo or not.
|
Thanks for your contribution! It's great work. Yeah I like "iregex" but pyparsing is better for this use case. I like iregex when I actually want to see regex string output. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes:
--inlineflag which hides an error line when the number of lines to show is set to 0. Since it's an offset for additional lines IMO 0 should still show the line with an error itself. At least I need this feature, if you don't like it, use the--inlineflag, when setting number of additional lines to 0;P.S.: Even though module import seems to be fixed and is working as of now, I still couldn't manage to make renag pre-commit hook to import module properly, so had to remove the
__init__.pyfile.P.S. 2: There are still issues with
examplesfolder and examples in the readme, but I really don't feel like fixing it as of today.