Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write into Theme-specific settings instead of global ones #8

Closed
usernamehw opened this issue Aug 26, 2019 · 4 comments
Closed

Write into Theme-specific settings instead of global ones #8

usernamehw opened this issue Aug 26, 2019 · 4 comments
Assignees

Comments

@usernamehw
Copy link
Contributor

  1. Try to lighten Activity Bar background
  2. Switch theme
  3. 馃悰 The color stayed

So, to iterate, instead of:

"workbench.colorCustomizations": {
    "activityBar.background": "#2f363c"
}

You do

"workbench.colorCustomizations": {
    "[Github]": {
        "activityBar.background": "#2f363c"
    }
}

Where Github is active theme that was modified by the extension.

@usernamehw
Copy link
Contributor Author

Theme id is from "workbench.colorTheme"

@ryanraposo ryanraposo self-assigned this Aug 26, 2019
@ryanraposo
Copy link
Owner

ryanraposo commented Aug 29, 2019

themeSpecificity

@usernamehw I want to keep the ability to write both generalized & theme-specific customizations to settings, but it has to be without further confusing the 'scoping' process.

Current dev build has this set up. (1) is implementation, (2) is a new setting called codeui.targetingMode, can equal 'general' or 'themeSpecific' and (3) is a statusbar toggle button/indicator for the setting. The two modes have the effect you would expect.

Thoughts?

@usernamehw
Copy link
Contributor Author

That would work for me.

@ryanraposo
Copy link
Owner

addressed in 0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants