Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Origin Checking #31

Closed
tsmada opened this issue May 26, 2020 · 1 comment
Closed

Go Origin Checking #31

tsmada opened this issue May 26, 2020 · 1 comment

Comments

@tsmada
Copy link
Collaborator

tsmada commented May 26, 2020

The websocket implementation (Gorilla) in Go is safe defaulting where the origin is being sent from the client when viewing from Chrome as file:// which does not match the host request header. The CheckOrigin function stub can be found here

It's currently returning true (allowing all Origin headers).

It would be good to allow localhost:* or any origins in a list supplied by env var.

@csjoblom
Copy link
Collaborator

Should be all fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants