New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
this.handleLoad
isn't a function
#234
Comments
Oh no, i don't see the error in any tests or on the demo page? Can you create a test case? |
same happening to me. Normal usage, but the child component has multiple iframes inside of it:
And then there is a parent component that imports this SafeDangerousImage:
|
Ok just leaving notes for myself and future readers: I can reproduce the error with any simple usage! Looking at the stack trace I can see Digging into the compiled src that ships in npm it seems that maybe babel doesn't correctly reference https://npmfs.com/package/react-frame-component/5.2.5/lib/Frame.js#L71 |
I've deprecated 5.2.5 for now on npm, but I think the fix might be to upgrade babel I did try migrating to v7 but still it left the this unchanged in the compiled code? I'm on vacation until the end of the month so can only look at this sporadically. If anyone has a fix happy to review an publish when I get time. |
Hi folks, I created a PR to fix the issue - please have a look whenever you get a chance ^ #236 |
Thanks everyone especially @dannysindra for doing the PR. Just released v5.2.6 |
When updating from 5.2.4 to 5.2.5
The text was updated successfully, but these errors were encountered: