"this" references are no longer transformed correctly in some cases

[nicketson]

The issue can be seen here

The expression this.shouldStay here

dom-expressions/packages/babel-plugin-jsx-dom-expressions/test/__dom_fixtures__/components/code.js

Line 120 in 12fb07c

<Component prop={this.something} onClick={() => this.shouldStay}>

should be transformed into _self$.shouldStay here

dom-expressions/packages/babel-plugin-jsx-dom-expressions/test/__dom_fixtures__/components/output.js

Line 360 in 12fb07c

onClick: () => this.shouldStay,

this is going to refer to the object literal being passed as the second argument to _$createComponent() instead of the this in the render function, which is what would be expected.

The bug was introduced in commit f8ea5cc

[ryansolid]

Interesting because it looks like that commit was very intentional to fix a different issue. Trying to track down that issue now, but it is proving elusive.

[titoBouzout]

Isn't the issue that the getters are using the current scope instead of the parent?
related ryansolid/mobx-jsx#44
curious enough, at the time I sent that issue, it only happens when you double nest a custom component, it doesn't happen if you double nest a regular div.