-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use acceptable name for GitHub token secret #10
Conversation
Hi @patik, Thanks for the contribution, I really appreciate it! Per the GitHub action docs:
The |
Codecov Report
@@ Coverage Diff @@
## main #10 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 1 1
Branches 1 1
=========================================
Hits 1 1 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patik @ryansonshine I think it would be easier to directly point to this part: https://github.com/semantic-release/github#github-authentication It explains in details which strategy to use depending on the need. (to be honest, I struggled some time with those... thinking I had to create it manually, but was setting At the end maybe the easiest way is to adjust the template to have in
It will grant needed permissions automatically. |
Thanks @sneko ! I agree I think an update to Let me know if you'd like to open a PR, otherwise I should be able to get around to this sometime in the new few days. |
This change adds the permissions required for the release workflow to use GITHUB_TOKEN. re #10
Closing this PR after implementing the changes proposed in #10 (comment) with f05e389 |
Change name for GitHub token
GitHub doesn't allow you to add a repository secret named
GITHUB_*
. This PR changes the name toGH_TOKEN
and also adds instructions to the readme.Pull-Request Checklist
main
branchnpm run lint
passes with this changenpm run test
passes with this changeFixes #0000