Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: exclude test files from build #19

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

smellai
Copy link
Contributor

@smellai smellai commented Oct 3, 2022

Description of change

With this change, test files will be not included in the build directory

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (2a4ad0c) compared to base (913bcd9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
  Branches         1         1           
=========================================
  Hits             1         1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ryansonshine
Copy link
Owner

Thanks for the contribution @smellai !

We'll also need to update the package.json's main value to point to ./lib/index.js

Copy link
Owner

@ryansonshine ryansonshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace value in package.json from:

{
  "main": "./lib/src/index.js",
}

to

{
  "main": "./lib/index.js",
}

@smellai
Copy link
Contributor Author

smellai commented Oct 5, 2022

would you like to make this PR eligible for hacktoberfest? (either add the hacktoberfest tag to the repositories tags or add the “hacktoberfest-accepted” label to the PRs)

I would like to open a couple of more PRs with small improvements.

@ryansonshine ryansonshine merged commit 00517e8 into ryansonshine:main Oct 5, 2022
@github-actions
Copy link

github-actions bot commented Oct 5, 2022

🎉 This PR is included in version 1.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants