Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for JupyterLab 3.6/4+ and Notebook v7+ #300

Merged
merged 1 commit into from
May 5, 2023

Conversation

mcrutch
Copy link
Contributor

@mcrutch mcrutch commented Apr 4, 2023

Closes #299 - Tested with Lab 3.6.0 (worked) Lab 4.0.0b0 (worked) Notebook v7a18 (worked) and forced a test with Lab 3.5.3 (didn't work)

@mcrutch
Copy link
Contributor Author

mcrutch commented Apr 4, 2023

Actually, realized I made the change to the editor lines (221/228) and haven't tested those, but need to go back and look for how those are triggered. Think we are good here to. Created a python file in Jupyter lab (as opposed to notebook) and that formatted correctly

@ryantam626
Copy link
Collaborator

Hi sorry for the late reply, I haven't given this project much love.

I am in middle to a big refactor for the project (mostly due to the evolution of jupyterlab's plugin tooling), I will just merge this PR without releasing a new version for now.

I will of course attribute this addition to you when I complete the refactor which should include your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JupyterLab 4(beta) support
2 participants