Are binary checks the responsibility of nixpkgs-update?

[raboof]

Shouldn't we encourage projects to add those in their installCheckPhase, like NixOS/nixpkgs#119636 ?

[ryantm]

@raboof I agree that it would be better for those checks to be upstreamed. If there was some default version check that checked the version of everything in the bin directory, that would probably be quite useful.

It may be preferable to use passthru.tests instead of installCheckPhase, since the later introduces overhead of every build. Also, passthru.tests can be executed independently of the build.

[ryantm]

nixpkgs-update and OfBorg run passthru.tests

[raboof]

It may be preferable to use passthru.tests instead of installCheckPhase, since the later introduces overhead of every build. Also, passthru.tests can be executed independently of the build.

Took me a while to figure out how exactly, so proposed NixOS/nixpkgs#119731

[raboof]

It may be preferable to use passthru.tests instead of installCheckPhase, since the later introduces overhead of every build. Also, passthru.tests can be executed independently of the build.

let's discuss this in NixOS/nixpkgs#119731 (comment)

[ryantm]

I think I will get rid of the binary checks. I don't think they work that well, are looked at much, and operationally they stall updates sometimes the programs hang around in a way it doesn't know how to kill.

[Artturin]

I look at the binary checks, and I can merge the pr without even building it if those pass and the upstream commits are okay.

[ryantm]

I removed binary checking.