Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if an update is in staging already #69

Closed
Mic92 opened this issue Aug 17, 2018 · 8 comments
Closed

Check if an update is in staging already #69

Mic92 opened this issue Aug 17, 2018 · 8 comments
Assignees
Labels

Comments

@Mic92
Copy link
Member

Mic92 commented Aug 17, 2018

Gdb was merged in staging:
NixOS/nixpkgs#44564
and the bot tried to merge it into master as well:
NixOS/nixpkgs#45235
NixOS/nixpkgs#44780

This probably does not happen too often, but it would be nice to have to detect this at some point.

@jtojnar
Copy link
Collaborator

jtojnar commented Aug 17, 2018

It already does check: https://github.com/ryantm/nixpkgs-update/blob/15f16444caed45b7da82f6b453c8923fa9340437/src/Update.hs#L144-L149. not sure what went wrong.

@ryantm
Copy link
Collaborator

ryantm commented Aug 18, 2018

I only update the branches every hour or so, but this is off by about 11 days, so probably something is wrong. I'll try to look into what's going on.

@ryantm
Copy link
Collaborator

ryantm commented Nov 19, 2018

Another issue like this: NixOS/nixpkgs#50738

@ryantm
Copy link
Collaborator

ryantm commented Nov 20, 2018

Another instance of the issue NixOS/nixpkgs#50821

@ryantm
Copy link
Collaborator

ryantm commented Nov 20, 2018

NixOS/nixpkgs#50827 similar issue

@ryantm
Copy link
Collaborator

ryantm commented Nov 29, 2018

Work on this will be related to #91

@ryantm
Copy link
Collaborator

ryantm commented Jan 3, 2019

Example of problem NixOS/nixpkgs#53345

@ryantm
Copy link
Collaborator

ryantm commented Jan 5, 2019

Yay, I finally figured out the cause of this bug! The issue is that when it checks for the old version being on staging or master, it only does a sub-string check. So in the case of gdb, it checked if 8.2 is in the derivation file, and of course it is because 8.2 is a sub-string of 8.2.1.

@ryantm ryantm closed this as completed in f48c6f0 Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants