Automated updates for buildRustPackage Applications #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhipple
force-pushed
the
feature/rust-update
branch
3 times, most recently
from
ad61f89
to
ca3d7a7
Compare
bhipple
force-pushed
the
feature/rust-update
branch
from
ca3d7a7
to
336aad5
Compare
ryantm
reviewed
Mar 5, 2020
ryantm
reviewed
Mar 5, 2020
bhipple
force-pushed
the
feature/rust-update
branch
2 times, most recently
from
2d8a696
to
b5d6a3a
Compare
bhipple
force-pushed
the
feature/rust-update
branch
from
b5d6a3a
to
3da9745
Compare
bhipple
changed the title
|
So far I have tested this by:
|
bhipple
commented
Mar 5, 2020
| numberOfHashes :: Text -> Int | ||
| numberOfHashes derivationContents = countUp "sha256 =" + countUp "sha256=" | ||
| numberOfHashes derivationContents = | ||
| sum $ map countUp ["sha256 =", "sha256=", "cargoSha256 =", "modSha256 ="] | ||
| where | ||
| countUp x = T.count x derivationContents |
There was a problem hiding this comment.
It'd be nice to get something that isn't a heuristic here; without my update, the regular version updater will kick and do a half-baked job on the Rust upgrade, since it thinks it just has 1 hash. This fixes it by teaching it about cargoSha256, and while I'm here adding modSha256 (the Go equivalent).
I haven't seen examples in the wild without the space before =, though it'd be nice if everything were hosed down with nixpkgs-fmt so that were an actual robust assumption.
ryantm
approved these changes
Mar 5, 2020
bhipple
added a commit
to bhipple/nixpkgs-update
that referenced
this pull request
Mar 13, 2020
Having merged an update to make go packages passthru the `modSha256` [1], we can now have `nixpkgs-update` inspect it and make updates, just as it now does for Rust packages as of [2]. As a slight detail, because the attribute is in `passthru` rather than actually being available in the derivation, we just do the equivalent of `nix eval -f . <attrPath>.<attr>` rather than going through the `drvAttrs` as before. [1] NixOS/nixpkgs#82027 [2] nix-community#156
bhipple
added a commit
to bhipple/nixpkgs-update
that referenced
this pull request
Mar 13, 2020
Having merged an update to make go packages passthru the `modSha256` [1], we can now have `nixpkgs-update` inspect it and make updates, just as it now does for Rust packages as of [2]. As a slight detail, because the attribute is in `passthru` rather than actually being available in the derivation, we just do the equivalent of `nix eval -f . <attrPath>.<attr>` rather than going through the `drvAttrs` as before. This version has been tested successfully with at least one go update [3], but not thoroughly vetted. That said, it's essentially identical to the Rust implementation that has been working well for some time now. [1] NixOS/nixpkgs#82027 [2] nix-community#156 [3] NixOS/nixpkgs#82465
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds our first non-trivial rewriter that makes real updates!