Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show user avatar and link to user profile #185

Open
ryanw-mobile opened this issue Apr 25, 2024 · 0 comments
Open

Show user avatar and link to user profile #185

ryanw-mobile opened this issue Apr 25, 2024 · 0 comments
Assignees
Labels
feature A new feature for the user, not a new feature for a build script.

Comments

@ryanw-mobile
Copy link
Owner

in API response, we have
"username": "",

username can be empty, but in case it doesn't, we have an additional block like this:

      "user": {
        "avatar_url": "...",
        "banner_image": "...",
        "banner_url": "...",
        "profile_url": "https://giphy.com/.../",
        "username": "...",
        "display_name": "...",
        "description": "",
        "instagram_url": "...",
        "website_url": "...",
        "is_verified": true
      },

So that:

  1. We have a display_name to show, rather than the raw username
  2. We have an avatar_url

There are many more possibilities, including showing the user details in a bottom sheet,
but for this stage, if an image comes with a username and the user{} object, we can replace the current "GIF" image type avatar with the actual user images.

@ryanw-mobile ryanw-mobile added the feature A new feature for the user, not a new feature for a build script. label Apr 25, 2024
@ryanw-mobile ryanw-mobile self-assigned this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature for the user, not a new feature for a build script.
Projects
None yet
Development

No branches or pull requests

1 participant