deletion of cname not always working

[Jeffote]

The deletion of "pihole_dns_record" is not always working and leaves the entry in pihole untouched.

pihole version: v5.17.3
provider version: 0.2.0

[rustyguts]

I ran into this when trying to add or remove lots of cnames from a list, though I get it with A records too. I converted my list to a set which solved the deletion issue. Now, Terraform is smart enough to only add or remove the domains that have changed. It may not fix the underlying cause but it's a workaround.

# Old
resource "pihole_cname_record" "this" {
  count  = length(local.all_cnames)
  domain = local.all_cnames[count.index]
  target = "ingress.example.local"
}

# New
resource "pihole_cname_record" "this" {
  for_each = toset(local.all_cnames)
  domain   = each.key
  target   = "ingress.example.local"
}

[jlilja]

Hi there! I believe I have a fix for this. Once the open PR(s) are accepted and merged, then I will rebase my PRs and create a new PR towards this repo.

My draft can be found here in the meantime jlilja#4