Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry headers handling in retry interceptor #105

Closed
UDarya opened this issue Jun 3, 2019 · 5 comments · May be fixed by #151
Closed

Retry headers handling in retry interceptor #105

UDarya opened this issue Jun 3, 2019 · 5 comments · May be fixed by #151
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@UDarya
Copy link

UDarya commented Jun 3, 2019

Please check this article https://developer.mozilla.org/ru/docs/Web/HTTP/%D0%97%D0%B0%D0%B3%D0%BE%D0%BB%D0%BE%D0%B2%D0%BA%D0%B8/Retry-After

@rybalkinsd rybalkinsd added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 4, 2019
@Russiancold
Copy link

Russiancold commented Aug 5, 2019

@rybalkinsd What if the retry-after delay is too large? And how should I couple this feature with old logic?

@rybalkinsd
Copy link
Owner

@Russiancold I think there should a limit, however, it's better to check how it's recommended to handle this delay

@Russiancold
Copy link

I believe that it can varies pretty much, so what about providing maxRetryTime field? If the header value overlimits it then it should be passed further to the chain then.

@rybalkinsd
Copy link
Owner

In our case, maxRetryTime should be somehow aligned with client connectTimeout, readTimeout and writeTimeout

So, it's probably no need to introduce a new variable, but use something based on existing

@rybalkinsd
Copy link
Owner

duplicate of #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants