Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add secondaryOffset #52

Merged
merged 1 commit into from Sep 9, 2022
Merged

Conversation

danReynolds
Copy link
Contributor

The latest version of Flutter master will require the addition of this secondaryOffset parameter. Not needed for now on stable but should be helpful to note for folks in the future.

@rydmike
Copy link
Owner

rydmike commented Sep 8, 2022

Thanks @danReynolds, I noticed as well when I was in on master yesterday that something new will be needed, but did not look into it yet.

Thanks for the PR, really appreciate it. I will look at it and merge it a bit later. Feeling a bit under the weather at the moment. Got Covid diagnosis confirmed today, despite 3 vaccine shots. Very mild symptoms so far, guess the shots are to be thanked for that.

Focusing on code seems tiring and increases my headache. Hope to be back to full speed soon though.

@danReynolds
Copy link
Contributor Author

Thanks @danReynolds, I noticed as well when I was in on master yesterday that something new will be needed, but did not look into it yet.

Thanks for the PR, really appreciate it. I will look at it and merge it a bit later. Feeling a bit under the weather at the moment. Got Covid diagnosis confirmed today, despite 3 vaccine shots. Very mild symptoms so far, guess the shots are to be thanked for that.

Focusing on code seems tiring and increases my headache. Hope to be back to full speed soon though.

Sorry to hear that you're under the weather. Speedy recovery! Take your time with the PR, no rush.

@codecov-commenter
Copy link

Codecov Report

Merging #52 (2e3f9b3) into master (6af74ef) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   65.56%   65.56%           
=======================================
  Files          23       23           
  Lines        2053     2053           
=======================================
  Hits         1346     1346           
  Misses        707      707           
Impacted Files Coverage Δ
lib/src/widgets/opacity/opacity_slider_track.dart 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rydmike rydmike merged commit 001a193 into rydmike:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants