Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An Optional feature request #17

Open
justkawal opened this issue Apr 29, 2021 · 2 comments
Open

An Optional feature request #17

justkawal opened this issue Apr 29, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@justkawal
Copy link

justkawal commented Apr 29, 2021

@rydmike Thanks for this awesome color picker and yeah also for adding the opacity support much faster than expected !!

In the near by future are you planning to optionally allow the user to have a linear gradient strip of color instead of having a ring one ??

Having a rectangular curved strip instead of a ring one as by the user's choice would be interesting.

I am although trying to understand your code of the Color Wheel Picker, but yeah there is a lot to be done as the pickers are currently on the ring.

You can find the gist here, as I've started to do some edits: https://gist.github.com/justkawal/cbb6e35d1a9ac4e1cb7a667b436ef096

@rydmike
Copy link
Owner

rydmike commented Apr 30, 2021

Thanks @justkawal for your feedback and comments.

Yes I do plan to add new picker types. I was panning add at least a traditional "advanced" one with sliders for the different color values, but also providing toggle to select if the sliders are used for:

  • RGB
  • HSL
  • HSV
  • CMYK
  • HSB

And enable copying color values in these formats too.

For the the wheel picker, replacing the wheel with a straight hue slider, above or below the square, is also a possibility. Thanks for this suggestion and idea.

It should be quite straight forward to add as an option, either via a variant that draws that instead of the circle. A simpler version is that it just removes the Hue circle and draws a custom slider instead, kind of like the opacity slider, but with a hue background. It could have an option for having it above or below the square and some styling options, like the opacity slider has. For keyboard navigation and accessibility the hue slider would solve the issue the wheel has, but the rectangle would still suffer from them. Although I think I could add some focus and keyboard nav to support to it too.

I also want to add maybe two different picker selector options, the current cupertino segmented slider does not support keyboard navigation, so it is not so nice for web/desktop, even if it looks pretty. I would probably add a custom variant of it with that support keyboard nav, and maybe add Material toggle buttons as another option for selecting which picker is used.

I also need to write a bunch of tests for FlexColorPicker. I need to do it before I start adding more features to ensure I don't start breaking stuff. Been a bit lazy with the tests. FlexColorScheme has almost 100% test coverage, but this one is very low, only some basic unit test of core functions.

At the moment I'm a bit tied up in other projects. Also started to look again at Flexfold and moving it forward to something that is on the level that it is worth to publish.

The good part, there is always something fun an interesting to tinker with. Any help is always welcome, even just suggestions and ideas, and hearing that someone is actually using or tinkering with something I published is always nice too. 😃

Related to: #19

@rydmike rydmike added the enhancement New feature or request label Apr 30, 2021
@justkawal
Copy link
Author

Would be waiting for it. 🔥

@rydmike rydmike self-assigned this Jan 27, 2024
@rydmike rydmike added this to the 4.0.0 milestone Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Proposed
Development

No branches or pull requests

2 participants