Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Decode error after migrating from plain text field #1

Closed
mijewe opened this issue May 1, 2019 · 2 comments
Closed

JSON Decode error after migrating from plain text field #1

mijewe opened this issue May 1, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@mijewe
Copy link

mijewe commented May 1, 2019

Hi,

It's getting an invalid argument exception on "yii\helpers\BaseJson::decode('01234 123 123')"

I think what's happened is I've moved from a plain text field with "01234 123 123" set, and now that's not valid JSON so it's getting upset.

@rynpsc rynpsc added the bug Something isn't working label May 3, 2019
@rynpsc
Copy link
Owner

rynpsc commented May 4, 2019

This will require some thought as we require both a region code and/or the number in international format e.g. +44. Ideally we'll take the existing value in this case "01234 123 123" and then try to convert it using the fields "Default Region", otherwise bail.

@rynpsc
Copy link
Owner

rynpsc commented May 5, 2019

Just released 1.2.3 which will prevent the error in the interim whilst I work out a better way of converting existing strings into phone numbers.

@rynpsc rynpsc closed this as completed May 5, 2019
Repository owner locked as resolved and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants