-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Excalidraw - PDF++ deep linking support #138
Comments
I have never cared about the compatibility with Excalidraw so far, but it's an interesting direction.
What exactly do you mean here? I quickly tested, and if I paste a link to a text selection into an Excalidraw canvas and save the change, the text was successfully highlighted: Screen.Recording.2024-04-04.at.0.19.01.movIf I click on the link, I can jump to the exact location of the text selection (it opens the same PDF file in a new tab, which is not great, but I cannot do anything since it's governed by Excalidraw, not PDF++). Also, if I cmd+hover over the highlight, I can preview the link in the Excalidraw file: Screen.Recording.2024-04-04.at.0.22.32.movDouble-clicking it can take me to the location of the link in the Excalidraw file: Screen.Recording.2024-04-04.at.0.23.08.movThe only thing I found weird is that Excalidraw sometimes, not always, displays the notification "I could not find a matching text element" when I do the same thing with the Excalidraw file already opened: Screen.Recording.2024-04-04.at.0.27.57.mov |
Yes I believe there is something need to be tweaked at Excalidraw side.. Screen.Recording.2024-04-04.at.06.56.33_resized.mp4Thansks for your time! |
I find when using Excalidraw in a new window, the backlink can bring you back to PDF++ in another window in a correct way. Another benefit is that both plugins will be faster than they stay in the same window. |
Hmm weird, I am still unable to get this deep linking even when I followed your direction. |
Describe your request
Hello Developers!
Thanks for your great work for this amazing plugin, your effort and work is immensely valuable for obsidian community.
I have one FR:
I notice that once we copied the highlighted pdf we are not getting the same result with pasting it on Excalidraw as in the markdown file (it s unable to deep linking in excalidraw), esp when both files are open
when we clicked to pdf files it also unable to pinpoint the excalidraw pasted highlight text and gives below notif
![image](https://private-user-images.githubusercontent.com/65077044/318993035-0041463f-9f1a-4dd8-a752-ad58795f44a4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2ODk2NTQsIm5iZiI6MTcxOTY4OTM1NCwicGF0aCI6Ii82NTA3NzA0NC8zMTg5OTMwMzUtMDA0MTQ2M2YtOWYxYS00ZGQ4LWE3NTItYWQ1ODc5NWY0NGE0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI5VDE5MjkxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNiYzFjNjEwYTIzZDhhZWUxOTQ0NGM2ZGMxM2RkMzU4MzQ5OTlmNTI3NTdjMGQ3NWM0M2FiYzUwNjlhNTQzZmQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.YL3urLqOj2-dhcLdA2nG1Xi0UlXuW1k3CGN84aUZ6_8)
It would be great if we can enhance this pdf++ experience by having visual representative of our pdf notes inside excalidraw canvas will full functionality.
Thanks again for this great plugin.
Cheers,
Denny
The text was updated successfully, but these errors were encountered: