Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Excalidraw - PDF++ deep linking support #138

Open
Dennyyusuf opened this issue Apr 3, 2024 · 4 comments
Open

[FR] Excalidraw - PDF++ deep linking support #138

Dennyyusuf opened this issue Apr 3, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Dennyyusuf
Copy link

Describe your request

Hello Developers!

Thanks for your great work for this amazing plugin, your effort and work is immensely valuable for obsidian community.
I have one FR:

I notice that once we copied the highlighted pdf we are not getting the same result with pasting it on Excalidraw as in the markdown file (it s unable to deep linking in excalidraw), esp when both files are open

image

when we clicked to pdf files it also unable to pinpoint the excalidraw pasted highlight text and gives below notif
image

It would be great if we can enhance this pdf++ experience by having visual representative of our pdf notes inside excalidraw canvas will full functionality.

Thanks again for this great plugin.

Cheers,
Denny

@Dennyyusuf Dennyyusuf added the enhancement New feature or request label Apr 3, 2024
@Dennyyusuf Dennyyusuf changed the title [FR] Excalidraw link support [FR] Excalidraw deep linking support Apr 3, 2024
@Dennyyusuf Dennyyusuf changed the title [FR] Excalidraw deep linking support [FR] Excalidraw - PDF++ deep linking support Apr 3, 2024
@RyotaUshio
Copy link
Owner

RyotaUshio commented Apr 3, 2024

I have never cared about the compatibility with Excalidraw so far, but it's an interesting direction.
I believe some decent level of integration cannot be achieved without the help of zsviczian, though.

it s unable to deep linking in excalidraw

What exactly do you mean here?

I quickly tested, and if I paste a link to a text selection into an Excalidraw canvas and save the change, the text was successfully highlighted:

Screen.Recording.2024-04-04.at.0.19.01.mov

If I click on the link, I can jump to the exact location of the text selection (it opens the same PDF file in a new tab, which is not great, but I cannot do anything since it's governed by Excalidraw, not PDF++).

Also, if I cmd+hover over the highlight, I can preview the link in the Excalidraw file:

Screen.Recording.2024-04-04.at.0.22.32.mov

Double-clicking it can take me to the location of the link in the Excalidraw file:

Screen.Recording.2024-04-04.at.0.23.08.mov

The only thing I found weird is that Excalidraw sometimes, not always, displays the notification "I could not find a matching text element" when I do the same thing with the Excalidraw file already opened:

Screen.Recording.2024-04-04.at.0.27.57.mov

@Dennyyusuf
Copy link
Author

Dennyyusuf commented Apr 4, 2024

Yes I believe there is something need to be tweaked at Excalidraw side..
For me when I annotate more than one highlight then when I click at excalidraw it can't pinpoint the location of the highlight inside the pdf

Screen.Recording.2024-04-04.at.06.56.33_resized.mp4

Thansks for your time!

@Rex-Diego
Copy link

I find when using Excalidraw in a new window, the backlink can bring you back to PDF++ in another window in a correct way. Another benefit is that both plugins will be faster than they stay in the same window.

@Dennyyusuf
Copy link
Author

I find when using Excalidraw in a new window, the backlink can bring you back to PDF++ in another window in a correct way. Another benefit is that both plugins will be faster than they stay in the same window.

Hmm weird, I am still unable to get this deep linking even when I followed your direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants