Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget namespace should be other than 'ui.' #16

Open
rdworth opened this issue Feb 15, 2012 · 2 comments
Open

Widget namespace should be other than 'ui.' #16

rdworth opened this issue Feb 15, 2012 · 2 comments

Comments

@rdworth
Copy link

rdworth commented Feb 15, 2012

The 'ui.' widget namespace is reserved for widgets that are part of the jQuery UI Suite (http://jqueryui.com/). It is intended that developers building their own widgets using the jQuery UI Widget Factory select their own namespace so as to avoid a collision with a current or future plugin of the same name in a suite maintained by a separate bunch of folks.

The fix is simple enough. On line https://github.com/ryrych/rcarousel/blob/master/widget/lib/jquery.ui.rcarousel.js#L2 just change 'ui' to a namespace of your choosing, such as 'r' or 'ry' or 'ryry' or 'ryrych' or something else entirely. Also, don't forget to update the filename to reflect the change. The filename should generally be jquery.namespace.widgetname.js

Thanks!

@ryrych
Copy link
Owner

ryrych commented Feb 15, 2012

Yes, I know. I read this text a few days ago. As I’m working now on a new version, this will be changed when it is released.
Thanks.

@ryrych
Copy link
Owner

ryrych commented Feb 15, 2012

Oh, sorry. I thought it relates to rlightbox that I’m working on now. Anyway it will also be changed in rcarousel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants