Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Change SGV data point colours based on high/low thresholds #7

Closed
bmammon opened this issue Apr 17, 2018 · 6 comments
Closed
Labels
enhancement New feature or request

Comments

@bmammon
Copy link

bmammon commented Apr 17, 2018

It would be great if the current BG number changed colour as well!

@Rytiggy
Copy link
Owner

Rytiggy commented Apr 17, 2018

I like this, I've added it to my todo list! great suggestion 😄

@Rytiggy Rytiggy added the enhancement New feature or request label Apr 17, 2018
@zshh
Copy link

zshh commented Apr 23, 2018

Just updated to latest official version.
BG high/low are by me defined as 9 and 4
Currently its 6.3 mmol and font color is red? Guess it shouldn't be like that? :)

edit: hmm my BG went down from 6.3 to 6.0 (displays as 6) and it's not red any more. Maybe just coincidence or bug with decimals, will update as soon as it changes to x.x something

@Rytiggy
Copy link
Owner

Rytiggy commented Apr 23, 2018

Thanks for bringing this up! I missed checking if the units_hint was mmol or mgdl for the color of the bg, Im betting if you switched it to mgdl it would not show the red. I'll make note of this and fix it soon!

@zshh
Copy link

zshh commented Apr 23, 2018

Cheers, same goes for the graph axis, you fixed it in earlier version to scale the numbers if mgdl or mmol, right now its stuck on the mgdl scale only tho ;)

Thanks for all the great work Ryan!

@Rytiggy
Copy link
Owner

Rytiggy commented Apr 23, 2018

I had a report of that this morning, I made the fix for the axis in mmol but haven't pushed the code.
glance-screenshot 26

No problem im enjoying it 😀

@Rytiggy
Copy link
Owner

Rytiggy commented Apr 24, 2018

Fixed with https://github.com/Rytiggy/Glance/tree/release/1.1.3

@Rytiggy Rytiggy closed this as completed Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants