Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for carpet avoidance to vacuums #1040

Closed
fettlaus opened this issue May 8, 2021 · 4 comments · Fixed by #1039
Closed

Add setting for carpet avoidance to vacuums #1040

fettlaus opened this issue May 8, 2021 · 4 comments · Fixed by #1039

Comments

@fettlaus
Copy link
Contributor

fettlaus commented May 8, 2021

As mentioned in #1039 newer vacuums like the Roborock S7 feature a setting for carpet avoidance. This settings allows for the robot to lift its mop while cleaning a carpet or alternatively avoiding carpets altogether.

I didn't find the setting by trial and error but it is present in the app.

Device information:

  • Model: roborock.vacuum.a15
  • Hardware version: Linux
  • Firmware version: 4.1.2_0978

Additional context

@rezmus
Copy link

rezmus commented May 9, 2021

getCarpetCleanMode: function getCarpetCleanMode() {
  return asyncCallMethod('get_carpet_clean_mode', [], {});
},

setCarpetCleanMode: function setCarpetCleanMode(status) {
  return asyncCallMethod('set_carpet_clean_mode', {"carpet_clean_mode": status}, {});
},
      
var CarPetCleanModeSettingMap = {
  CarPetCleanModeNoneForbidden: 2,
  CarPetCleanModeMopForbidden: 1,
  CarPetCleanModeAllForbidden: 0
};

@fettlaus
Copy link
Contributor Author

fettlaus commented May 9, 2021

Added this feature to currently open PR #1039
@rezmus Thanks!

@rytilahti
Copy link
Owner

Let's keep this open until it gets merged, I added closes mark so it'll be done automatically when that happens :-)

@rytilahti rytilahti reopened this May 11, 2021
@fettlaus
Copy link
Contributor Author

Let's keep this open until it gets merged, I added closes mark so it'll be done automatically when that happens :-)

Thanks. I'm still new to this whole "contribute back to OSS" thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants