Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI tool demands an IP address always #36

Closed
syssi opened this issue Aug 3, 2017 · 2 comments
Closed

CLI tool demands an IP address always #36

syssi opened this issue Aug 3, 2017 · 2 comments

Comments

@syssi
Copy link
Collaborator

syssi commented Aug 3, 2017

It looks like I'm unable to work appropriate with the cli tool. ;-)

$ ./mirobo discover
Usage: mirobo [OPTIONS] COMMAND [ARGS]...

Error: Invalid value for "--ip": Invalid IP: None does not appear to be an IPv4 or IPv6 address

$ ./mirobo --ip 192.168.13.1 discover
Traceback (most recent call last):
  File "./mirobo", line 11, in <module>
    load_entry_point('python-mirobo==0.1.2', 'console_scripts', 'mirobo')()
  File "/home/sebastian/.local/lib/python3.5/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/home/sebastian/.local/lib/python3.5/site-packages/click/core.py", line 696, in main
    with self.make_context(prog_name, args, **extra) as ctx:
  File "/home/sebastian/.local/lib/python3.5/site-packages/click/core.py", line 621, in make_context
    self.parse_args(ctx, args)
  File "/home/sebastian/.local/lib/python3.5/site-packages/click/core.py", line 1018, in parse_args
    rest = Command.parse_args(self, ctx, args)
  File "/home/sebastian/.local/lib/python3.5/site-packages/click/core.py", line 880, in parse_args
    value, args = param.handle_parse_result(ctx, opts, args)
  File "/home/sebastian/.local/lib/python3.5/site-packages/click/core.py", line 1404, in handle_parse_result
    self.callback, ctx, self, value)
  File "/home/sebastian/.local/lib/python3.5/site-packages/click/core.py", line 78, in invoke_param_callback
    return callback(ctx, param, value)
  File "/home/sebastian/.local/lib/python3.5/site-packages/mirobo/vacuum_cli.py", line 32, in validate_token
    token_len = len(value)
TypeError: object of type 'NoneType' has no len()

Do I miss something? The behaviour is the same for version 0.1.2 and the current master. Thanks in advance!

@rytilahti
Copy link
Owner

Thanks, this was somehow overlooked.

@syssi
Copy link
Collaborator Author

syssi commented Aug 6, 2017

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants