Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make netifaces optional dependency #964

Closed
rytilahti opened this issue Mar 9, 2021 · 0 comments · Fixed by #970
Closed

Make netifaces optional dependency #964

rytilahti opened this issue Mar 9, 2021 · 0 comments · Fixed by #970
Labels

Comments

@rytilahti
Copy link
Owner

Describe the bug
Installing python-miio on Windows fails when no Visual C++ is installed ("error: Microsoft Visual C++ 14.0 is required").
As this is only used by the updater, it would make sense to make this dependency optional to enable easier installation on Windows platforms.

Found while investigating #951.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant