Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown link rendering doesn't look right #34

Open
ryu1kn opened this issue Sep 24, 2022 · 9 comments
Open

Markdown link rendering doesn't look right #34

ryu1kn opened this issue Sep 24, 2022 · 9 comments
Labels
bug Something isn't working

Comments

@ryu1kn
Copy link
Owner

ryu1kn commented Sep 24, 2022

The link part of rendering is not done right.

image

The markdown in the changelog is as follows. It looks legit to me 👁️

## [1.1.0] - 2022-09-24
### Added
- Extension changelogs are now collapsible. Giving easier access to the next extension changelog, without having to scroll for long time. (thanks to @jerone [PR #31](https://github.com/ryu1kn/vscode-extension-update-reporter/issues/31))

### Fixed
- Fixed the issue where it failed to find a version heading prefix when the version string appears more than once in a heading. (thanks to @jerone [PR #28](https://github.com/ryu1kn/vscode-extension-update-reporter/issues/28))
@ryu1kn ryu1kn added the bug Something isn't working label Sep 24, 2022
@ryu1kn
Copy link
Owner Author

ryu1kn commented Sep 24, 2022

On GitHub UI, the changelog looks like this. This is what I'd expect to see.

image

https://github.com/ryu1kn/vscode-extension-update-reporter/blob/1bd52a6cd1bd9a01ff66afccf8c25e8735284266/CHANGELOG.md

@jerone
Copy link
Collaborator

jerone commented Sep 24, 2022

Other extension links are working correctly:
image

It looks like #31 is automatically converted to a link, ignoring the link syntax around it...

@jerone
Copy link
Collaborator

jerone commented Sep 24, 2022

It's the same on the Marketplace: https://marketplace.visualstudio.com/items/ryu1kn.extension-update-reporter/changelog

image

@ryu1kn
Copy link
Owner Author

ryu1kn commented Sep 25, 2022

Wow, thanks for the investigation @jerone ! It might be better reported to Marketplace (or packager?) 😉 I'll close this issue once I file this to somewhere.

@jerone
Copy link
Collaborator

jerone commented Sep 26, 2022

@jerone
Copy link
Collaborator

jerone commented Sep 26, 2022

Weirdly enough, markdown-it renders correctly. See playground.

image

So, why are VSCode & MarketPlace rendering it differently...

@jerone
Copy link
Collaborator

jerone commented Sep 26, 2022

It gets even weirder; it is rendering correctly now:

image

@jerone
Copy link
Collaborator

jerone commented Apr 5, 2023

I'm still having this issue once in a while.
But I cannot reproduce this issue in development.
Need clear steps to reproduce the issue, before finding out what the issue could be.

@jerone
Copy link
Collaborator

jerone commented Sep 16, 2023

Version Lens (1.6.0 ➡ 1.7.1) pflannery.vscode-versionlens
image
https://marketplace.visualstudio.com/items/pflannery.vscode-versionlens/changelog
https://gitlab.com/versionlens/vscode-versionlens/-/blob/1.7.1/CHANGELOG.md?ref_type=tags&plain=1#L67-75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants