Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find and add new animes to list #40

Closed
2 tasks done
mparadinha opened this issue Jan 20, 2017 · 7 comments
Closed
2 tasks done

Find and add new animes to list #40

mparadinha opened this issue Jan 20, 2017 · 7 comments

Comments

@mparadinha
Copy link
Contributor

mparadinha commented Jan 20, 2017

When I do mal search it only shows results that are already on my animelist. Don't know if this was intended, but it would be nice to have that feature as well as being able to add an anime to the list (maybe a add command).
I noticed that the MyAnimeList.search is not used anywhere in the codebase and it seems to be there for this exact purpose.

  • implement new search command
  • implement add command
@alexkubica
Copy link
Contributor

It does make sense to search all animes on this command. We can make an option for the list command that would use the current search implementaion there and change the search command to search for all animes.

@mparadinha
Copy link
Contributor Author

mparadinha commented Jan 22, 2017

I think we should leave the current behaviour of search in the same command but via an option like --mine. This way mal search regex would search everything and mal search regex --mine would only search in the users list. Although --mine might not be the best name, not sure.

@ryukinix
Copy link
Owner

Yes, we can use the mal search regex as described here. But I propose instead add a new flag for mal search regex --mine we can use just mal filter regex. Add a bunch of flags will let the CLI complicated very fast. I prefer add a new command filter when search changed to find all animes on MAL.

@ryukinix ryukinix modified the milestone: 3.0 Jan 24, 2017
@ryukinix
Copy link
Owner

Maybe we can finish that in the next release. For now I'll remove from the release of today.

@ryukinix ryukinix removed this from the v0.3.0 milestone Jan 31, 2017
@mparadinha
Copy link
Contributor Author

The search and filter commands are basically implemented over at search-filter but there's a problem with the synopsis (it prints bold tags and the like). Should we just merge it and open an issue to later fix it, or wait till we figure it out?

@ryukinix
Copy link
Owner

ryukinix commented Feb 2, 2017

Let's wait. After fix the HTML tags we can merge it.

@mparadinha
Copy link
Contributor Author

Fixed the HTML tags in #52. All that's left is to do something to add new animes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants