Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promisify animation updates #35

Closed
ryuuart opened this issue May 8, 2023 · 1 comment
Closed

Promisify animation updates #35

ryuuart opened this issue May 8, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ryuuart
Copy link
Owner

ryuuart commented May 8, 2023

This will take some figuring out, but everything should be updated before drawing. Especially for #34 .

@ryuuart ryuuart added the enhancement New feature or request label May 8, 2023
@ryuuart ryuuart self-assigned this May 8, 2023
@ryuuart
Copy link
Owner Author

ryuuart commented May 12, 2023

I believe that everything does happen synchronously with updates since they're called in context of a loop, inside a render function, not inside a promise. What I believe should be happening is that each invocation of the functions during update() and draw() are adding execution stack frames across the board. If there are promises in these stack frames, they're still handled after execution of all these frames (in the microtask queue). So in other words, what I'm saying is that update() should be assumed synchronous until it doesn't show that behavior. After all, we update the entire system synchronously, so it's hard for me to imagine.

@ryuuart ryuuart closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant