Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicates #636

Closed
mathieujobin opened this issue Jun 21, 2022 · 2 comments
Closed

Prevent duplicates #636

mathieujobin opened this issue Jun 21, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@mathieujobin
Copy link

Describe the bug
When we don't merge the PR, or let the repo unsupervised, new PR gets added every other day with the same changes.
Could rubocop_challenger check if the PR is already open, and either open a PR fixing a different rule automatically, that would be best.
or do nothing if that's simpler first step.

Error information
N/A

RubocopChallenger version (please complete the following information):

  • 2.7.0

RuboCop versions (please complete the following information):

$ grep '^    rubocop' Gemfile.lock 
    rubocop (1.30.1)
    rubocop-ast (1.18.0)
    rubocop-performance (1.14.2)
    rubocop-rails (2.14.2)
    rubocop-rake (0.6.0)
    rubocop-rspec (2.11.1)
    rubocop-thread_safety (0.4.4)
    rubocop_challenger (2.7.0)

Additional context
To many things to do... want to reduce noise and duplicate stuff

@mathieujobin mathieujobin added the bug Something isn't working label Jun 21, 2022
@ryz310
Copy link
Owner

ryz310 commented Jun 21, 2022

Hi, @mathieujobin

Hmm... I think this is not a bug, but an operational issue.
You can reduce rubocop challenge execution frequency. If you want to open a PR fixing a different rule, you can use a random mode that:

rubocop_challenger go \
  --email=email@example.com \
  --name=your_name \
  --mode=random

But I also want to prevent duplicates. Please see #205.
I will try. Thank you.

@mathieujobin
Copy link
Author

Thank you for the suggestion of using --mode=random I think that will help a lot

I will close this since this is duplicate of #205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants