Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@NonNull should be allowed on abstract methods #1011

Closed
cristian-mocanu-mob opened this issue Jan 27, 2016 · 1 comment
Closed

@NonNull should be allowed on abstract methods #1011

cristian-mocanu-mob opened this issue Jan 27, 2016 · 1 comment

Comments

@cristian-mocanu-mob
Copy link

Lombok throws an error when using @NonNull on abstract method (in abstract class or interface): @NonNull is meaningless on a parameter of an abstract method.

@NonNull not meaningless in this situation.
It is actually very useful for documentation purposes.

Also, to keep things easy to understand, probably Lombok should require @NonNull for implementations of these methods (even for abstract overrides - e.g. add a throws declaration in a subclass).

@rspilker
Copy link
Collaborator

rspilker commented Feb 1, 2016

Already fixed in issue #807 and available in the edge release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants