New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lombok installer does not work with SpringSource Tool Suite 2.1.0.RELEASE #95

Closed
lombokissues opened this Issue Jul 14, 2015 · 12 comments

Comments

Projects
None yet
4 participants
@lombokissues
Collaborator

lombokissues commented Jul 14, 2015

Migrated from Google Code (issue 22)

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 sam.brannen   🕗 Aug 06, 2009 at 10:41 UTC

What steps will reproduce the problem?

  1. Run the installer JAR
  2. Select STS.app in the SpringSource Tool Suite folder

What is the expected output?

The installer should accept STS.app as the Eclipse installation.

What do you see instead?

An error dialog is displayed stating that "The path does not appear to
contain an Eclipse installation: .../STS.app".

The installer can not continue, because you simply cannot select STS.app.

What version of the product are you using? On what operating system?

Lombok v0.8.2
Mac OS X 10.5.7
STS 2.1.0.RELEASE

Please provide any additional information below.

In general the installer should not rely on the name of the application,
since an Eclipse installation can be called anything (e.g., STS instead of
Eclipse).

Collaborator

lombokissues commented Jul 14, 2015

👤 sam.brannen   🕗 Aug 06, 2009 at 10:41 UTC

What steps will reproduce the problem?

  1. Run the installer JAR
  2. Select STS.app in the SpringSource Tool Suite folder

What is the expected output?

The installer should accept STS.app as the Eclipse installation.

What do you see instead?

An error dialog is displayed stating that "The path does not appear to
contain an Eclipse installation: .../STS.app".

The installer can not continue, because you simply cannot select STS.app.

What version of the product are you using? On what operating system?

Lombok v0.8.2
Mac OS X 10.5.7
STS 2.1.0.RELEASE

Please provide any additional information below.

In general the installer should not rely on the name of the application,
since an Eclipse installation can be called anything (e.g., STS instead of
Eclipse).

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 sam.brannen   🕗 Aug 06, 2009 at 10:54 UTC

Specifically, EclipseFinder.getEclipseExecutableName() should not rely on hard-coded
values. This technique is very brittle. Why not just assume the user knows what he is
doing and use the file he selected? You could of course issue a warning dialog to
confirm that the selected file truly is the Eclipse executable.

Collaborator

lombokissues commented Jul 14, 2015

👤 sam.brannen   🕗 Aug 06, 2009 at 10:54 UTC

Specifically, EclipseFinder.getEclipseExecutableName() should not rely on hard-coded
values. This technique is very brittle. Why not just assume the user knows what he is
doing and use the file he selected? You could of course issue a warning dialog to
confirm that the selected file truly is the Eclipse executable.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Sep 01, 2009 at 23:02 UTC

Click on 'what does this installer do?' and follow instructions. Before I accept this issue, let's first confirm that
lombok can in fact work with STS? There's also the issue of STS's internal structure: Does it have an eclipse.ini
file? If STS named it sts.ini, then the lombok installer will have to a bit more heuristic magic to figure out which
ini file it needs to modify.

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Sep 01, 2009 at 23:02 UTC

Click on 'what does this installer do?' and follow instructions. Before I accept this issue, let's first confirm that
lombok can in fact work with STS? There's also the issue of STS's internal structure: Does it have an eclipse.ini
file? If STS named it sts.ini, then the lombok installer will have to a bit more heuristic magic to figure out which
ini file it needs to modify.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 rocknroll.demon   🕗 Sep 03, 2009 at 16:53 UTC

STS does rename the ecplise.ini to STS.ini. I'm having the same issue on both win
and mac. Hopefully you can accept this issue as I would very much like to use lombok
in STS 2.1.0.

Collaborator

lombokissues commented Jul 14, 2015

👤 rocknroll.demon   🕗 Sep 03, 2009 at 16:53 UTC

STS does rename the ecplise.ini to STS.ini. I'm having the same issue on both win
and mac. Hopefully you can accept this issue as I would very much like to use lombok
in STS 2.1.0.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Oct 16, 2009 at 09:57 UTC

As I said, click on 'what does this installer do' and walk through the steps. I'm not sure if it'll 'just work'. if it
does, you'll have a lombok-ized STS. If it doesn't, we know more.

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Oct 16, 2009 at 09:57 UTC

As I said, click on 'what does this installer do' and walk through the steps. I'm not sure if it'll 'just work'. if it
does, you'll have a lombok-ized STS. If it doesn't, we know more.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 kinglew   🕗 Dec 02, 2009 at 02:10 UTC

I can confirm that lombok works on STS 2.2 by manually modifying the STS.ini
But as the initial post says, it would be much better if the installation would work
straight from the jar...

at least that fix would guarantee the "get lombok to work in less than 12 sec" :)

Collaborator

lombokissues commented Jul 14, 2015

👤 kinglew   🕗 Dec 02, 2009 at 02:10 UTC

I can confirm that lombok works on STS 2.2 by manually modifying the STS.ini
But as the initial post says, it would be much better if the installation would work
straight from the jar...

at least that fix would guarantee the "get lombok to work in less than 12 sec" :)

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Dec 02, 2009 at 09:26 UTC

I'm already doing work on the installer to find netbeans, so, I'll try, but I'm guessing you don't know how much
hoops we have to jump through to give you the nice 'here are a bunch of eclipses we found for you' feature in
the installer. Without an actual copy of STS on all platforms that STS runs on, I have no idea where to look.
Perhaps you know.

specifically:

On windows, what's the usual place STS gets installed - specifically, what is the name of the folder usually?
"STS"?

Is there a mac version? Is it distributed as a zip containing amongst other things STS.app, and is there an
STS.ini file in STS.app/Contents/MacOS/STS.ini?

is it written capitalized (STS.ini) or lowercase? (sts.ini)?

Is there a linux installer? What does that do?

Is STS in any frequently used apt repository?

Without answers I can try something simple that will at least accept manually entered paths to STS, but auto-
discovery would be out of the question.

As springsource seems to be a for pay utility, I can't get these answers myself.

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Dec 02, 2009 at 09:26 UTC

I'm already doing work on the installer to find netbeans, so, I'll try, but I'm guessing you don't know how much
hoops we have to jump through to give you the nice 'here are a bunch of eclipses we found for you' feature in
the installer. Without an actual copy of STS on all platforms that STS runs on, I have no idea where to look.
Perhaps you know.

specifically:

On windows, what's the usual place STS gets installed - specifically, what is the name of the folder usually?
"STS"?

Is there a mac version? Is it distributed as a zip containing amongst other things STS.app, and is there an
STS.ini file in STS.app/Contents/MacOS/STS.ini?

is it written capitalized (STS.ini) or lowercase? (sts.ini)?

Is there a linux installer? What does that do?

Is STS in any frequently used apt repository?

Without answers I can try something simple that will at least accept manually entered paths to STS, but auto-
discovery would be out of the question.

As springsource seems to be a for pay utility, I can't get these answers myself.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 sam.brannen   🕗 Dec 02, 2009 at 12:04 UTC

FYI: STS is free. You can download all of the versions that you need here:

http://www.springsource.com/products/springsource-tool-suite-download

Regarding the Mac, yes, there are actually several versions available for Mac OS X
for both Carbon and Cocoa, 32-bit and 64-bit, with both .tar.gz and .dmg download
options. You will see all available options on the download page (link above). Yes,
the installation contains STS.app, and STS.ini is stored under
"STS.app/Contents/MacOS/STS.ini" (with that exact capitalization).

For Linux there are both .installer.sh and .tar.gz downloads for 32-bit and 64-bit.

STS is not in apt: it is only available via the SpringSource download page (see link
above).

Collaborator

lombokissues commented Jul 14, 2015

👤 sam.brannen   🕗 Dec 02, 2009 at 12:04 UTC

FYI: STS is free. You can download all of the versions that you need here:

http://www.springsource.com/products/springsource-tool-suite-download

Regarding the Mac, yes, there are actually several versions available for Mac OS X
for both Carbon and Cocoa, 32-bit and 64-bit, with both .tar.gz and .dmg download
options. You will see all available options on the download page (link above). Yes,
the installation contains STS.app, and STS.ini is stored under
"STS.app/Contents/MacOS/STS.ini" (with that exact capitalization).

For Linux there are both .installer.sh and .tar.gz downloads for 32-bit and 64-bit.

STS is not in apt: it is only available via the SpringSource download page (see link
above).

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

👤 reinierz   🕗 Dec 08, 2009 at 05:09 UTC

The STS clickthrough license says I may not reverse engineer it.

You're lucky in live in a country with, at least for now, still sane laws, so I can ignore that part, and probably
the entire shrinkwrap license. It's nice they've given me the right to give feedback though. Lawyers. You'd
laugh if you weren't already crying.

Installer has been updated to (auto)detect STS installations and will find any STS installed by using the official
STS installer on windows, linux, or macs.

The commit with these changes is c3a3c09, and it'll be released in
v0.9.2 "hailbunny", which shouldn't be long now.

Collaborator

lombokissues commented Jul 14, 2015

👤 reinierz   🕗 Dec 08, 2009 at 05:09 UTC

The STS clickthrough license says I may not reverse engineer it.

You're lucky in live in a country with, at least for now, still sane laws, so I can ignore that part, and probably
the entire shrinkwrap license. It's nice they've given me the right to give feedback though. Lawyers. You'd
laugh if you weren't already crying.

Installer has been updated to (auto)detect STS installations and will find any STS installed by using the official
STS installer on windows, linux, or macs.

The commit with these changes is c3a3c09, and it'll be released in
v0.9.2 "hailbunny", which shouldn't be long now.

@lombokissues

This comment has been minimized.

Show comment
Hide comment
@lombokissues

lombokissues Jul 14, 2015

Collaborator

End of migration

Collaborator

lombokissues commented Jul 14, 2015

End of migration

Tradunsky pushed a commit to Tradunsky/lombok that referenced this issue Aug 19, 2015

@atankala

This comment has been minimized.

Show comment
Hide comment
@atankala

atankala Dec 1, 2015

Rename the file "STS.EXE" to "sts.exe" under ../sts-bundle/sts.app/Contents/MacOS/.
And then run java -jar lomobok.jar and select the STS.ini file under ../sts-bundle/sts.app/Contents/Eclipse

This worked for me.

atankala commented Dec 1, 2015

Rename the file "STS.EXE" to "sts.exe" under ../sts-bundle/sts.app/Contents/MacOS/.
And then run java -jar lomobok.jar and select the STS.ini file under ../sts-bundle/sts.app/Contents/Eclipse

This worked for me.

@magicofdiety

This comment has been minimized.

Show comment
Hide comment
@magicofdiety

magicofdiety Sep 8, 2017

Rename the file "STS.EXE" to "sts.exe" worked for me. Thanks.

magicofdiety commented Sep 8, 2017

Rename the file "STS.EXE" to "sts.exe" worked for me. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment