New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always return ShadowClassLoader. #1138

Merged
merged 1 commit into from Jun 28, 2016

Conversation

Projects
None yet
2 participants
@liudongmiao
Contributor

liudongmiao commented Jun 23, 2016

It fixes lombok 1.16 doesn't works in maven-compiler-plugin 2.3.2 or old.
http://stackoverflow.com/questions/34358689

Furthermore, maven-compiler-plugin 2.4 requires plexus-compiler-javac 1.8.6, which drops org.codehaus.plexus.compiler.javac.IsolatedClassLoader.

I love hack, but hate such hard code to fix possible problem.

@rspilker

This comment has been minimized.

Show comment
Hide comment
@rspilker

rspilker Jun 27, 2016

Collaborator

This fix looks good. Can you please add your name to the AUTHORS file, so we are legally covered?

Collaborator

rspilker commented Jun 27, 2016

This fix looks good. Can you please add your name to the AUTHORS file, so we are legally covered?

always return ShadowClassLoader.
It fixes `lombok` `1.16` doesn't works in `maven-compiler-plugin` `2.3.2` or old.
http://stackoverflow.com/questions/34358689

Furthermore, `maven-compiler-plugin` `2.4` requires `plexus-compiler-javac` `1.8.6`, which drops
`org.codehaus.plexus.compiler.javac.IsolatedClassLoader`.

I love hack, but hate such hard code to fix possible problem.
@liudongmiao

This comment has been minimized.

Show comment
Hide comment
@liudongmiao

liudongmiao Jun 28, 2016

Contributor

Just added.

Contributor

liudongmiao commented Jun 28, 2016

Just added.

@rspilker rspilker merged commit b3ae90b into rzwitserloot:master Jun 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment