always return ShadowClassLoader. #1138

Merged
merged 1 commit into from Jun 28, 2016

Projects

None yet

2 participants

@liudongmiao
Contributor
liudongmiao commented Jun 23, 2016 edited

It fixes lombok 1.16 doesn't works in maven-compiler-plugin 2.3.2 or old.
http://stackoverflow.com/questions/34358689

Furthermore, maven-compiler-plugin 2.4 requires plexus-compiler-javac 1.8.6, which drops org.codehaus.plexus.compiler.javac.IsolatedClassLoader.

I love hack, but hate such hard code to fix possible problem.

@rspilker
Collaborator
rspilker commented Jun 27, 2016 edited

This fix looks good. Can you please add your name to the AUTHORS file, so we are legally covered?

@liudongmiao liudongmiao always return ShadowClassLoader.
It fixes `lombok` `1.16` doesn't works in `maven-compiler-plugin` `2.3.2` or old.
http://stackoverflow.com/questions/34358689

Furthermore, `maven-compiler-plugin` `2.4` requires `plexus-compiler-javac` `1.8.6`, which drops
`org.codehaus.plexus.compiler.javac.IsolatedClassLoader`.

I love hack, but hate such hard code to fix possible problem.
2ce427e
@liudongmiao
Contributor

Just added.

@rspilker rspilker merged commit b3ae90b into rzwitserloot:master Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment