-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On-Demand and Electron@latest #79
Comments
Yeah... electron constantly gives some issues regarding version. I would rather add support for one version of the electron, which works and specify this in the documentation. For example current latest 8.x |
🚢 |
They changed the way, how cookies are handled (now promises-based). But that was the only change. Tested with 8.x and upcoming 9.x - works fine. |
Thank you Sergei, as always! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I had a couple of requests with On-Demand strategy with issues dependent on the installed Electron version.
It would be great to check what was introduced in Electron v8 which breaks the current implementation of On-Demand strategy. I didn't have such a chance yet but maybe will take a look sooner.
The existing workaround (which I personally stick to for a while) is rolling back to v6, it is acceptable but not optimal as the default expectation for a user is to install the latest one. Looks like Electron always introduces breaking changes in arguments. Maybe we should have a strategy to support the last 2-3 versions and have fallback approaches.
The text was updated successfully, but these errors were encountered: